[ 
https://issues.apache.org/jira/browse/HBASE-29843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-29843.
-------------------------------
    Fix Version/s: 3.0.0-beta-2
     Hadoop Flags: Reviewed
     Release Note: 
Introduce a new setProprity(int, TableName) method in HBaseRpcController and 
move the priority calculating logic into the implementation of this method in 
the HBaseRpcControllerImpl class.

The default implementation in the HBaseRpcController interface is to call 
setPriority(int) and then setPriority(TableName), to simulate the old behavior 
in sync client on branch-2.

The two old method setPriority(int) and setPriority(TableName) are deprecated 
and will be removed in 4.0.0.
       Resolution: Fixed

Pushed to master and branch-3.

Thanks [~stoty] for the finding and [~wchevreuil], [~paksyd], [~RichardAntal] 
for reviewing!

> HBaseRPCController.setPriority(final TableName tn) is never called on 
> branch-3+
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-29843
>                 URL: https://issues.apache.org/jira/browse/HBASE-29843
>             Project: HBase
>          Issue Type: Bug
>          Components: rpc
>    Affects Versions: 3.0.0-beta-1
>            Reporter: Istvan Toth
>            Assignee: Duo Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.0.0-beta-2
>
>
> HBaseRPCController makes it possible to set the priority based on the table 
> name of an operation.
> This has stopped working on branch-3+.
> It is set at 
> [https://github.com/apache/hbase/blob/8c69ba12f6daf853e4bd5ee78ab01a6f1a88eb89/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java#L122]
> on branch-2, but it is never called on branch-3 + .



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to