Xiao Liu created HBASE-30261:
--------------------------------

             Summary: Hide segmented CodeHeap memory pools on process info JSP 
pages for JDK 9+
                 Key: HBASE-30261
                 URL: https://issues.apache.org/jira/browse/HBASE-30261
             Project: HBase
          Issue Type: Improvement
          Components: UI
            Reporter: Xiao Liu
            Assignee: Xiao Liu
             Fix For: 2.7.0, 3.0.0-beta-2, 2.5.16, 2.6.7
         Attachments: p1.png, p2.png, p3.png

On the process info pages ({{processMaster.jsp}} and {{processRS.jsp}}), the
memory pool loop skips code cache pools via:

{code:java}
if (mp.getName().contains("Cache")) continue;
{code}

This only matches the JDK 8 pool name "Code Cache". Since JDK 9 (JEP 197:
Segmented Code Cache), the code cache is split into three pools named
{{CodeHeap 'non-nmethods'}}, {{CodeHeap 'profiled nmethods'}} and
{{CodeHeap 'non-profiled nmethods'}}. None of them contain "Cache", so on
JDK 9+ (including 11/17/21) these three pools are no longer skipped and show
up on the page, which was not intended.

*Fix:* also skip pools whose name contains "CodeHeap", keeping the existing
"Cache" check for JDK 8 compatibility. Applied to both {{processMaster.jsp}}
and {{processRS.jsp}}.

The unrelated "Commited" -> "Committed" header typo on the same tables is
fixed together.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to