Hi all,

Could someone please help review the following six PRs? They cover test 
isolation, timing issues, and nightly validation. I've grouped them below for 
easier review.

Test isolation and cleanup

HBASE-30096 / #8577 — Split concurrent TestHRegion tests into smaller 
classes, improve background thread cleanup on failure, and bound StoreFile 
growth through compaction. Both regular and in-memory MemStore coverage are 
retained.

HBASE-29620 / #8623 — Isolate the mixed-version RSGroup scenario in a 
separate test class and simulate the target RegionServer's version through a 
test HMaster, removing the reflection-based change to process-wide VersionInfo 
state.

HBASE-29270 / #8793 — Give the replication source test a fresh root 
directory, restore temporary configuration, and fully shut down both mini 
clusters to avoid directory conflicts and leftover resources.

Test runtime and timing

HBASE-30093 / #8587 — Reduce the same-host replica balancing fixture while 
retaining multiple RegionServers per host and the replica-placement assertions. 
Following review feedback, the revised patch preserves the existing balancer 
timeout behavior.

HBASE-29213 / #8764 — Start timing before constructing 
RegionNormalizerWorker, so permits accumulated by its RateLimiter before 
measurement do not cause a false failure of the five-second assertion.

Nightly validation

HBASE-30491 / #8802 — Run TestShadedTestingUtilJarContents against the 
packaged JAR in the nightly shadedjars stage, alongside the existing invariant 
checks. This follows the discussion under HBASE-30452: #8789 fixed clean test 
by skipping the check when classes are loaded from a directory, and this 
follow-up ensures nightly builds still check the actual JAR for bundled JUnit 
libraries.

Validation details are included in each PR. I'd appreciate feedback on any of 
these changes, or suggestions for appropriate reviewers.

Thanks for your time!

Best regards,
Ma Zhengxuan




Pluto
[email protected]

Reply via email to