On Sun, 2008-04-27 at 18:04 +0100, sebb wrote: > 2008/4/27 sebb <[EMAIL PROTECTED]>: > > 2008/4/26 Oleg Kalnichevski <[EMAIL PROTECTED]>: > > > > > Folks, > > > > > > _Please_ do try to find a few minutes to review the release notes and > > > the packages for the coming release. > > > > > > Release notes: > > > > > http://people.apache.org/~olegk/httpclient-4.0-alpha4-preview/RELEASE_NOTES.txt > > > > > > Packages: > > > http://people.apache.org/~olegk/httpclient-4.0-alpha4-preview/packages/ > > > > > > > Not had time to review thoroughly yet, but there are quite a few > > instances of toLowerCase() - and some of toUpperCase() - which don't > > specify the Locale. > > > > These should probably mostly/all use Locale.ENGLISH, otherwise there > > may be problems in some Locales, e.g. Turkey, where "i".toUpperCase() > > is not equal to "I" - and vice-versa. > > > > The isSpecialDomain() method in NetscapeDomainHandler is one instance > > where the code won't always work in Turkey. > > > > But given that this is an Alpha Preview, I suppose these fixes could > > be deferred. > > > > > > Two more minor points: > - POM inceptionYear = 2000, but NOTICE says 1999 > - junit 3.8.2 would be better than 3.8.1, given that the code does not > need to compile/test on Java 1.3.
Fixed. Thanks, Sebastian Oleg > > > > > > Oleg > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
