[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Kalnichevski resolved HTTPCLIENT-770.
------------------------------------------

    Resolution: Fixed

Patch checked in with some minor tweaks. I am also not quite sure the use of 
chars instead of strings really makes a difference. So, I left a number of 
occurrences unchanged, mainly in the exception messages.

Many thanks, Paul

Oleg 

> Code cleanups for Java 1.5 and more.
> ------------------------------------
>
>                 Key: HTTPCLIENT-770
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-770
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>            Reporter: Paul Lindner
>            Priority: Minor
>             Fix For: 4.0 Alpha 4
>
>         Attachments: httpclient-cleanups.patch
>
>
> I can't resist giving code a good cleansing when I start hacking.  Here's 
> some simple things:
> - Use character constants instead of string contstants
> - Use java 1.5 style for loops
> - Use StringBuilder where appropriate
> - Fix javadocs
> - switch somestring.equals("") to .length() == 0
> -  simplify some boolean expressions
> - eliminate redundant initializers
> - fix some html nits
> - remove final keyword from static methods

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to