I didn't mean to imply that we should break compatibility with Android. Sorry if it sounded that way. I will create a new implementation of HttpRequest. However, I stand by what I said that the functionality to modify the uri and only the uri of a request should be in core. Rae
----- Original Message ---- From: Oleg Kalnichevski <[EMAIL PROTECTED]> To: HttpComponents Project <[email protected]> Sent: Friday, September 5, 2008 5:18:05 PM Subject: Re: HttpCore - #setUri method On Fri, 2008-09-05 at 17:07 -0700, Rae Egli wrote: > Is there a better or at least alternate way? It seems obvious that a URI > needs to be modified in a number of circumstances. Shouldn't this be > accomodated within core instead of a wrapper? > > Rae > Rae, You have a point, but I do not think this case warrants breaking compatibility with Android. One can always put together a custom implementation of HttpRequest with all the additional functionality a particular application requires. Besides, in many cases one will be much better off creating a new HttpRequest object instead of modifying properties of an existing one (especially when proxying requests). Oleg > > > ----- Original Message ---- > From: Bob Lee <[EMAIL PROTECTED]> > To: HttpComponents Project <[email protected]> > Sent: Friday, September 5, 2008 4:38:32 PM > Subject: Re: HttpCore - #setUri method > > On Fri, Sep 5, 2008 at 4:34 PM, Oleg Kalnichevski <[EMAIL PROTECTED]> wrote: > > > Bad news. I'll have to revert this change due to the objection raised by > > Bob Lee of the Android project. This change rendered HttpCore > > incompatible with the version shipped with Google Android. > > > > FWIW, we modify the URI of a request using RequestWrapper. > > Thanks, > Bob --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
