On 27/10/2008, Oleg Kalnichevski <[EMAIL PROTECTED]> wrote: > On Mon, 2008-10-27 at 20:13 +0000, sebb wrote: > > On 27/10/2008, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > Author: olegk > > > Date: Mon Oct 27 09:08:27 2008 > > > New Revision: 708225 > > > > > > URL: http://svn.apache.org/viewvc?rev=708225&view=rev > > > Log: > > > Fixed broken #parse(HeaderElement[], CookieOrigin) method in the > RFC2965Spec cookie spec > > > > > > > <snip/> > > > > > > > This does not look right - the header is using Set-Cookie, not Set-Cookie2 > > > > Sebastian > > I have not yet gotten around to fixing the Best-Match policy. When > RFC2965 is used standalone, however, it think it should treat Set-Cookie > and Set-Cookie2 consistently, but I am open to alternative ideas >
But the test is in the BestMatchSpec test class... It should be checking that Set-Cookie does not create a SetCookie2 and that the default host is "localhost". At present it just confirms the incorrect behaviour. I'd suggest fixing the test, and commenting it out until Best-Match is fixed. At least then it would clear what the eventual intention is. Also, I don't think that RFC2965 used alone should treat Set-Cookie headers as if they were Set-Cookie2. Seems to me it should either reject such headers entirely, or process them according to the RFC2019 spec. > Oleg > > > > S/// > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
