sebb wrote:
On 09/02/2009, sebb <[email protected]> wrote:
On 07/02/2009, Oleg Kalnichevski <[email protected]> wrote:

...

 >  Sebastian,
 >
 >  (1) Made sure all instance variables in SessionRequestImplare marked as
 > volatile.
 >  (2) Documented BasicHttpParams / BasicHttpProcessor as potentially
 > thread-unsafe.
 >  (3) Opened this issue for HttpClient
 >
 >  https://issues.apache.org/jira/browse/HTTPCLIENT-824
 >
 >  Does this address your concerns? Can we proceed with the release?


Sorry for the delay in replying. I'm away from base (trying to avoid
 getting snowed in) and don't have access to my normal system.

 I cannot check if that solves all the problems, but there's no point
 holding up the release further. At least users have been warned.

 If there are threading issues they will have to be addressed in a later 
release.

 So +0 from me.


I think it would be worth making the HashMap in BasicHttpParams final,
and using clear() rather than setting the Map to null. This would make
it easier to maintain thread-safety later.

Any objections?


No objections from me. Please go ahead with the change.

Oleg


 >  Oleg
 >
 >
 > ---------------------------------------------------------------------
 >  To unsubscribe, e-mail: [email protected]
 >  For additional commands, e-mail: [email protected]
 >
 >


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to