On 04/06/2009, [email protected] <[email protected]> wrote: > Author: olegk > Date: Thu Jun 4 18:07:42 2009 > New Revision: 781814 > > URL: http://svn.apache.org/viewvc?rev=781814&view=rev > Log: > Javadoc fix > > Modified: > > httpcomponents/httpcore/branches/4.0.x/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedInputBuffer.java > > httpcomponents/httpcore/branches/4.0.x/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedOutputBuffer.java > > Modified: > httpcomponents/httpcore/branches/4.0.x/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedInputBuffer.java > URL: > http://svn.apache.org/viewvc/httpcomponents/httpcore/branches/4.0.x/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedInputBuffer.java?rev=781814&r1=781813&r2=781814&view=diff > > ============================================================================== > --- > httpcomponents/httpcore/branches/4.0.x/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedInputBuffer.java > (original) > +++ > httpcomponents/httpcore/branches/4.0.x/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedInputBuffer.java > Thu Jun 4 18:07:42 2009 > @@ -39,7 +39,7 @@ > /** > * Implementation of the {...@link ContentInputBuffer} interface that can be > * shared by multiple threads, usually the I/O dispatch of an I/O reactor and > - * a worker tread. This class is not threading safe. > + * a worker thread. This class is thread safe.
Are you sure it is thread-safe? It looks like the super-class (ExpandableBuffer) is not thread-safe - for example the mode field is mutable and is not synchronized by the available() and hasData() public methods, nor are these methods overridden by SharedInputBuffer. Similarly for SharedOutputBuffer below. > * @since 4.0 > */ > > Modified: > httpcomponents/httpcore/branches/4.0.x/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedOutputBuffer.java > URL: > http://svn.apache.org/viewvc/httpcomponents/httpcore/branches/4.0.x/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedOutputBuffer.java?rev=781814&r1=781813&r2=781814&view=diff > > ============================================================================== > --- > httpcomponents/httpcore/branches/4.0.x/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedOutputBuffer.java > (original) > +++ > httpcomponents/httpcore/branches/4.0.x/httpcore-nio/src/main/java/org/apache/http/nio/util/SharedOutputBuffer.java > Thu Jun 4 18:07:42 2009 > @@ -39,7 +39,7 @@ > /** > * Implementation of the {...@link ContentOutputBuffer} interface that can be > * shared by multiple threads, usually the I/O dispatch of an I/O reactor and > - * a worker tread. This class is not threading safe. > + * a worker thread. This class is thread safe. > * > * @since 4.0 > */ > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
