[
https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746831#action_12746831
]
Oleg Kalnichevski commented on HTTPCLIENT-866:
----------------------------------------------
OK. Now it is my turn to have a second thought about this whole situation.
If we have to add this [1] to every NOTICE and LICENSE file in every assembly
and jar of HttpClient I am beginning to have doubts it is worth the trouble.
For instance, NOTICE and LICENSE resources in jars get automatically generated
by Maven remote-resources plugin for us, which is quite convenient. At the very
least we would have to maintain our own resource bundle for HttpClient, which
seems a bit too much, given the current project composition.
How about just replacing JCIP annotations with comments until there is a
version of JCIP annotations maintained by ASF?
@Immutable -> //@Immutable
Oleg
[1] http://creativecommons.org/licenses/by/2.5/legalcode
> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
> Key: HTTPCLIENT-866
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.0 Final
> Environment: javac 1.5.0_19
> Reporter: David Nault
> Priority: Critical
> Attachments: HTTPCLIENT-866.patch
>
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar
> must be in the classpath or else you get a compiler error:
> [javac] /path/to/src/SomeFile.java:129: cannot access
> net.jcip.annotations.GuardedBy
> [javac] file net/jcip/annotations/GuardedBy.class not found
> [javac] DefaultHttpClient httpclient = new DefaultHttpClient();
> [javac] ^
> With Java 6, you get a bunch of warnings instead.
> [javac]
> org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class):
> warning: Cannot find annotation method 'value()' in type
> 'net.jcip.annotations.GuardedBy': class file for
> net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and
> jcip-annotations.jar is not included in the
> "httpcomponents-client-4.0-bin-with-dependencies" package.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
