[ 
https://issues.apache.org/jira/browse/HTTPCORE-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760204#action_12760204
 ] 

Oleg Kalnichevski commented on HTTPCORE-208:
--------------------------------------------

Hi Asankha

Conceptually, IOReactorExceptionHandler should not be receiving exceptions that 
are I/O session related. Events related to a particular I/O session are meant 
to be handled by the IOEventDispatch. 

IOReactorExceptionHandler is intended for handling of 
(1) I/O errors caused by a problem with the I/O reactor itself rather than an 
individual I/O session (such as a failure to open a listener)
(2) Runtime exceptions caused by a bug in the I/O reactor implementation
(3) Runtime exceptions not handled by IOEventDispatch

If you want to handle a runtime exception caused by a particular I/O session, 
you just have to make sure it is caught on the IOEventDispatch level, where you 
always have access to the underlying I/O session.

Does this make any sense?

Oleg

> Pass the IOSession along with the Exception to the registered 
> IOReactorExceptionHandler
> ---------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-208
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-208
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>    Affects Versions: 4.1-alpha1
>            Reporter: Asankha C. Perera
>            Assignee: Asankha C. Perera
>            Priority: Minor
>             Fix For: 4.1-beta1
>
>
> Currently an IOReactorExceptionHandler is only passed the exception 
> encountered by the reactor. The BaseIOReactor which ultimately calls the 
> exception handler could pass the IOSession to the exception handler. With 
> this, the exception handlers down the line could be enhanced to close the 
> session/connection (if its not closed) or use the information for reporting 
> purposes etc, such as connection details for the failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to