[
https://issues.apache.org/jira/browse/HTTPCLIENT-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783874#action_12783874
]
Oleg Kalnichevski commented on HTTPCLIENT-895:
----------------------------------------------
I do not think that reverting back to using static logs would be such a good
idea. We just need to make sure that no Log object lookups take place on
critical execution paths. That is, there no Log objects should be created on a
per request basis. Objects created in the course of request execution should be
reusing Log object of the HttpClient instance.
Oleg
> Log creation impairs performance
> --------------------------------
>
> Key: HTTPCLIENT-895
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-895
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 4.0 Final
> Reporter: Tony Poppleton
> Priority: Minor
> Attachments: HTTPCLIENT-895.patch
>
>
> Running JProfiler on a program that uses HttpClient with a
> ThreadSafeClientConnManager, revealed that 5% of the time was spent
> constructing Log instances in class ClientParamsStack.
> Oleg did some further investigation and found that DefaultRequestDirector
> also has the same problem.
> A simple solution would be to make the Log a static member variable, and do
> this on all classes for consistency. However this might not be the best
> solution for interoperating with some frameworks (see
> http://wiki.apache.org/jakarta-commons/Logging/StaticLog)
> Another solution would be to simply remove the Log from the affected classes,
> although they are presumably there for a reason...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
