[
https://issues.apache.org/jira/browse/HTTPCLIENT-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved HTTPCLIENT-906.
-----------------------------
Resolution: Fixed
According to Java Generics and Collections (O'Reilly) Chapter 16, LinkedHashMap
has slightly worse performance overall than HashMap, and should only be used if
insertion or access order is important. That makes sense, because the LHM has
to maintain its links.
BTW, when providing updated patches, it may be clearer to replace the original
file with a new one.
IIf the old file is to be kept, please use a fixed type (e.g. .patch) and
change the file stem (e.g. try3.patch), otherwise the attachment may be treated
as binary.
I've applied the patch without the change to use LHM.
URL: http://svn.apache.org/viewvc?rev=899957&view=rev
Log:
HTTPCLIENT-906 Minor performance improvement to IdleConnectionHandler
Replace keySet() + get() with entrySet()
Modified:
httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/IdleConnectionHandler.java
> Minor performance improvement to IdleConnectionHandler
> ------------------------------------------------------
>
> Key: HTTPCLIENT-906
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-906
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Reporter: Tony Poppleton
> Priority: Minor
> Fix For: 4.1 Alpha2
>
> Attachments: IdleConnectionHandler.java.patch,
> IdleConnectionHandler.java.patch2, IdleConnectionHandler.java.patch3
>
>
> The attached patch does the following changes to IdleConnectionHandler
> - as it iterator over a map of connections, using a LinkedHashMap is a faster
> - rather than using an iterator over the keyset and subsequently getting the
> values, an iterator over the entry set is used instead for efficiency (at
> least according to FindBugs)
> Note that the patch contains other changes to make variables final where
> possible. This was done automatically by Eclipse, and can be removed if
> desired. However I see no harm in them, other than they affect more of the
> code than intended by the patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
