On 21/03/2010, Oleg Kalnichevski <ol...@apache.org> wrote:
> Folks
>
>  Please DO try to find a few minutes to review the release notes and release
> packages for the coming HttpCore 4.1-beta1

Since this is the last chance to change the API, I have been having a
look at the visibility and mutability of fields.

AbstractHttpEntity
has 3 protected fields, however there are public getters/setters for
all of the fields, so it seems to me that the fields should be
private. That would allow synch. to be added later if necessary.

HttpEntityWrapper
- wrappedEntity should be final.

AbstractHttpMessage
- headerGroup should be final
- params should be private

BasicHttpProcessor
requestInterceptors and responseInterceptors should be final
Should also be private, otherwise subclasses can subvert the non-null condition

>  Release notes:
> http://people.apache.org/~olegk/httpcore-4.1-beta1-preview/RELEASE_NOTES.txt

I did not quite understand the following sentence:

"HttpCore based on
classic (blocking) I/O model is expected to be 5% to 10% faster
compared to previous releases. "

Does this mean that previous releases were not based on the classic
I/O model, and that changing to it has made the improvement?

Or are these two independent facts:
HttpCore is based on the classic (blocking) I/O model.
This release is expected to be 5% to 10% faster than previous releases

>  Release packages:
> http://people.apache.org/~olegk/httpcore-4.1-beta1-preview/

DOAP probably does not belong in the source archive (or elsewhere).

It's now 2010; Notice file needs updating.

Otherwise looks OK.

>  If I hear no complaints I will proceed with building the official release
> packages in a few days.
>
>  Oleg
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
>  For additional commands, e-mail: dev-h...@hc.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to