[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857200#action_12857200
 ] 

Asankha C. Perera commented on HTTPCLIENT-926:
----------------------------------------------

Hi Jean-Philippe

I was testing this and noticed that the Base64.encodeBase64String() inserts a 
CRLF even when the size is much less than 76 characters.. and thus causes 
problems (a connection reset from Amazon for a GET request in my test)

// base64-encode the hmac
result = Base64.encodeBase64String(rawHmac);

A simple replace as follows fixes this issue, but as I am not much familiar 
with the AWS/S3 API want to check this with you if this indeed is a simple 
oversight or if there could be other cases I am not aware of

// base64-encode the hmac
return Base64.encodeBase64URLSafeString(rawHmac);

cheers
asankha


> Add Amazon S3 authentication support
> ------------------------------------
>
>                 Key: HTTPCLIENT-926
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-926
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: Contrib
>            Reporter: Jean-Philippe Steinmetz
>             Fix For: 4.1 Alpha2
>
>         Attachments: AWSScheme.java, AWSSchemeFactory.java
>
>
> Add support for the the Amazon S3 authentication scheme as defined by the 
> online document: 
> http://docs.amazonwebservices.com/AmazonS3/latest/index.html?RESTAuthentication.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to