Thanks, Oleg!

At the moment the 4_0_API_FREEZE build matches 127 signatures, so a
tie with beta1.

But I'm looking closely at the diff, and I see one change that should
increase the match count:


  336 +++ 
module-client/src/main/java/org/apache/http/conn/ssl/SSLSocketFactory.java
 (.../4.0-beta1) (revision 937733)
    337 @@ -216,6 +216,20 @@
    338          this(TLS, null, null, truststore, null, null);
    339      }
    340
    341 +    public SSLSocketFactory(
    342 +        final SSLContext sslContext,
    343 +        final HostNameResolver nameResolver)
    344 +    {
    345 +        this.sslcontext = sslContext;
    346 +        this.socketfactory = this.sslcontext.getSocketFactory();
    347 +        this.nameResolver = nameResolver;
    348 +    }
    349 +
    350 +    public SSLSocketFactory(final SSLContext sslContext)
    351 +    {
    352 +        this(sslContext, null);
    353 +    }
    354 +


So I'm trying to dig deeper into that to see why my tool is messing up.


My tool also missed this, but it can't handle inner classes yet:

    201 +++ 
module-client/src/main/java/org/apache/http/impl/client/DefaultHttpClient.java

    231 +    // FIXME: remove this class when protocol interceptors in HttpCore
    232 +    // are updated to ignore CONNECT methods
    233 +    static class IgnoreConnectMethod implements
HttpRequestInterceptor {
    234 +



yours,

Julius


On Sat, Apr 24, 2010 at 1:46 AM, Oleg Kalnichevski <[email protected]> wrote:
> On Fri, 2010-04-23 at 13:08 -0700, Julius Davies wrote:
>> I'm developing a tool to try and match random jar files against known jar 
>> files.
>>
>> I ran the tool against the Android-7 jar file
>> (android-sdk-linux_86/platforms/android-7/android.jar), and here's
>> what my tool returned:
>>
>>
>>
>> Best match:  'httpcore-4.0-beta2.jar' with 92 matching signatures.
>>
>> Best match:  'httpclient-4.0-beta1.jar' with 127 matching signatures.
>>
>
> It think this is pretty accurate. I have always thought Android shipped
> with HttpCore 4.0b2 and a snapshot of HttpClient taken a few days before
> 4.0b1
>
> http://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4_0_API_FREEZE/
>
> You might want to build the snapshot and see if it produces a better
> match.
>
> Cheers
>
> Oleg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>



-- 
yours,

Julius Davies
250-592-2284 (Home)
250-893-4579 (Mobile)

$ sudo apt-get install cowsay
$ echo "Moo." | cowsay | cowsay -n | cowsay -n
http://juliusdavies.ca/cowsay/

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to