[
https://issues.apache.org/jira/browse/HTTPCLIENT-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870129#action_12870129
]
Sebb commented on HTTPCLIENT-937:
---------------------------------
Thanks, that's a lot better, but there are still some spurious import changes.
I've now had a more detailed look at the proposed changes.
I'm not sure that using ByteArrayEntity helps - the class is not immutable, as
it exposes the byte array to subclasses. Furthermore its constructor does not
copy the input array, so the caller can change the array after construction.
AFAICT, this just moves the mutable items to a different class, but perhaps I'm
missing something here.
> Make CacheEntry use an immutable object to represent cache content
> -------------------------------------------------------------------
>
> Key: HTTPCLIENT-937
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-937
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: Cache
> Reporter: Oleg Kalnichevski
> Fix For: 4.1 Alpha3
>
> Attachments:
> Making_CacheEntry_return_HttpEntity_for_getBody_NO_TESTS.patch,
> Making_CacheEntry_return_HttpEntity_for_getBody_TESTS_ONLY.patch
>
>
> Make CacheEntry use an immutable object to represent cache content similar to
> HttpEntity
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
