[
https://issues.apache.org/jira/browse/HTTPCORE-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888297#action_12888297
]
Oleg Kalnichevski commented on HTTPCORE-230:
--------------------------------------------
I see nothing wrong with the patch but I do not think it should be committed.
Performance metrics are not particularly cheap and often are useful only when
troubleshooting performance / networking issues. They should not be a part of
the framework, but should be added when really required through custom
extensions. In your particular case you can avoid having to patch HttpCore code
by creating a custom response parser which extends AbstractMessageParser.
Oleg
> Need time related metrics data
> ------------------------------
>
> Key: HTTPCORE-230
> URL: https://issues.apache.org/jira/browse/HTTPCORE-230
> Project: HttpComponents HttpCore
> Issue Type: New Feature
> Components: HttpCore
> Reporter: Zhang Guilin
> Fix For: 4.1
>
> Attachments: Sample_Metrics.txt
>
>
> I found this issue HTTPCORE-181 raised before.
> I got the similar requirement that we want to measure all kinds of
> time-related data to get the performance report such as:
> 1. DNS parsing time
> 2. Connection setup time
> 2. header parsing time
> 3. body transfer time
> ...
> I found that there are a lot of "private" fields which have no setter method
> in this component, this makes us hard to extend the functionality.
> For example in org.apache.http.impl.io.AbstractSessionInputBuffer#init()
> method, it would be better to change "this.metrics = new
> HttpTransportMetricsImpl();" to "this.metrics = createMetrics()" (a protected
> method） which subclasses can easily override this if they want to get an
> extended HttpTransportMetricsImpl instance.
> Can some one look at this feature?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
