[
https://issues.apache.org/jira/browse/HTTPCORE-235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oleg Kalnichevski resolved HTTPCORE-235.
----------------------------------------
Resolution: Invalid
> While this code will appear to work, especially on loopback and local
> connections, it is flawed long-haul where connections are often dropped early.
In this case an I/O exception will be thrown. Besides, the proper message
delimitation is enforced by the protocol handlers. I do not think EntityUtils
is the right place for this kind logic.
Having said that, there is always a choice of using a custom HttpEntity helper
for to string or to byte array conversions where additional validation logic
could be implemented.
Oleg
> EntityUtils.toString() doesn't detect/report less content being returned than
> was promised
> ------------------------------------------------------------------------------------------
>
> Key: HTTPCORE-235
> URL: https://issues.apache.org/jira/browse/HTTPCORE-235
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore
> Affects Versions: 4.0.1
> Reporter: Steve Loughran
>
> Also on my review of EntityUtils.toString(), I see that it's code to take an
> input stream and a content length only uses the content length parameter to
> set the size of the buffer -there is no attempt to verify that the amount of
> data received was as expected and raise an {{IOException}} if less data
> arrived.
> While this code will appear to work, especially on loopback and local
> connections, it is flawed long-haul where connections are often dropped
> early.
> I propose streaming the entity content to a byte array, validating the
> length, then building a string in the appropriate charset from the buffer if
> it is valid.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
