On Wed, 2010-09-22 at 17:13 +0100, sebb wrote: > On 22 September 2010 16:29, Oleg Kalnichevski <[email protected]> wrote: > > On Tue, 2010-09-21 at 23:23 +0100, sebb wrote: > >> The comments added for the @deprecated tags in > >> > >> r932551 - Deprecated HttpEntity#consumeContent in favor of a more > >> standard InputStream#close contract > >> > >> do not seem to make sense. > >> > > > > Sebastian, if the comment is unclear or ambiguous please do feel free to > > rephrase it. The idea is that one needs to do one of two things to > > ensure proper deallocation of resources associated with a HTTP entity: > > either call HttpEntity#writeOut() or call InputStream#close() on the > > s/writeOut/writeTo/ > > > object returned by HttpEntity#getContent() > > OK, will update the Javadoc. > > One other oddity - the AbstractHttpEntity implementation throws > UnsupportedOperationException, whereas none of the others do. > > Is that intended? If not, then EntityTemplate does not need to override it. >
#consumeContent() method was introduced by Roland and I never really liked it nor truly understood the need for it. So, I simply can't tell if it was intentional and what was the rationale for it. Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
