[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922115#action_12922115
 ] 

Jonathan Moore commented on HTTPCLIENT-1005:
--------------------------------------------

Hi Oleg,

I think exposing those is fine, although if HttpCache (and BasicHttpCache) are 
package-private, then no one will be able to actually instantiate one of those 
classes to pass to CachingHttpClient's constructor.

So I think we can leave HttpCacheStorage and HttpCacheEntry public (although, 
again, my preference would be NOT to do this until someone requested it) but we 
then need to provide a way for someone to actually instantiate a 
CachingHttpClient just from something implementing HttpCacheStorage. This 
probably consists of additional constructors on CachingHttpClient that take 
HttpCacheStorage in place of HttpCache (where the implementation just wraps 
those in a BasicHttpCache).

Jon


> API surface of caching module can be reduced
> --------------------------------------------
>
>                 Key: HTTPCLIENT-1005
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1005
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: Cache
>    Affects Versions: 4.1 Alpha2
>            Reporter: Jonathan Moore
>         Attachments: smaller-api.patch
>
>
> While the caching module can currently be considered functional and useful 
> for folks as-is, there are several near-term enhancements planned that could 
> change the exposed binary API of the caching module (although it is not yet 
> clear whether they would or not). In an effort to allow the 4.1 GA release to 
> go forward while hedging bets against future development, we should consider 
> drastically reducing the exposed binary API of the caching module, and not 
> exposing extension points until someone explicitly asks for them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to