DefaultConnectingIOReactor leaks socket descriptors if connections fail
-----------------------------------------------------------------------
Key: HTTPCORE-240
URL: https://issues.apache.org/jira/browse/HTTPCORE-240
Project: HttpComponents HttpCore
Issue Type: Bug
Affects Versions: 4.0.1
Reporter: Mohan Rao
> We are using HttpCore 4.0.1
>
> Also in particular in DefaultConnectingIOReactor -
>
> SocketChannel socketChannel;
> try {
> socketChannel = SocketChannel.open();
> socketChannel.configureBlocking(false);
> } catch (IOException ex) {
> throw new IOReactorException("Failure opening socket", ex);
> }
> try {
> validateAddress(request.getLocalAddress());
> validateAddress(request.getRemoteAddress());
>
> if (request.getLocalAddress() != null) {
> socketChannel.socket().bind(request.getLocalAddress());
> }
> boolean connected =
> socketChannel.connect(request.getRemoteAddress());
> if (connected) {
> prepareSocket(socketChannel.socket());
> ChannelEntry entry = new ChannelEntry(socketChannel,
> request);
> addChannel(entry);
> return;
> }
> } catch (IOException ex) {
> request.failed(ex);
> return;
> }
>
>
> In the above code - should the socketChannel be closed before request.failed
> is called ?
>
« [hide part of quote]
You are right. It should be but it is not. Please raise an issue in JIRA
for this defect.
Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
