+1 from me to release. The missing headers aren't a blocker in my opinion as the files are covered by the top level license and the header is just to make that really clear, so its ok to just add them for next time.
...ant On Mon, Nov 15, 2010 at 8:20 AM, Asankha C. Perera <[email protected]> wrote: > On 11/14/2010 05:24 AM, sebb wrote: >> >> RAT reports several files without AL headers: >> >> httpclient-cache/src/main/java/org/apache/http/impl/client/cache/BasicHttpCache.java >> >> httpclient-cache/src/test/java/org/apache/http/impl/client/cache/AbstractProtocolTest.java >> >> httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestHttpCacheEntrySerializers.java >> >> httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolAllowedBehavior.java >> >> httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestResponseCache.java > > Four of these classes are tests.. do you think we should recall the vote or > shall we fix it later? I prefer the latter.. > > thanks > asankha > > -- > Asankha C. Perera > AdroitLogic, http://adroitlogic.org > > http://esbmagic.blogspot.com > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
