Enabling wire logging changes isEof/isStale behavior
----------------------------------------------------
Key: HTTPCLIENT-1041
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1041
Project: HttpComponents HttpClient
Issue Type: Bug
Components: HttpClient
Affects Versions: 4.0.3
Reporter: Pasi Eronen
Priority: Minor
If you enable wire logging, DefaultClientConnection wraps the SocketInputBuffer
with a LoggingSessionInputBuffer. This hides the EofSensor interface
implemented by SocketInputBuffer (but not LoggingSessionInputBuffer), which
makes at least AbstractHttpClientConnection.isEof() and isStale() methods
behave differently.
(That is, stale connection checks won't really work as intended if wire logging
is enabled. Which makes it a bit difficult to debug problems related to stale
connections...)
Proposed fix: implement EofSensor interface in LoggingSessionInputBuffer
(delegating it to wrapped buffer).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
