[
https://issues.apache.org/jira/browse/HTTPCLIENT-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050445#comment-13050445
]
Christian Daszenies commented on HTTPCLIENT-1086:
-------------------------------------------------
Tahnk you for the fix. However I thing the change in URLEncodedUtils contains a
lot of duplicate code. Shouldn't it be sufficent to change the message
signature from
public static String format (final List<? extends NameValuePair> parameters,
final String encoding) {...
to
public static String format (final Iterable<? extends NameValuePair>
parameters, final String encoding) {...
as List extends Iterable (same with Constructors in UrlEncodedFormEntity)
> Use Iterable<? extends UrlEncodedFormEntity> instead of List<? extends
> UrlEncodedFormEntity> in URLEncodedUtils.format and UrlEncodedFormEntity
> -----------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1086
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1086
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Reporter: Marc McCloud
> Priority: Minor
> Fix For: 4.2 Alpha1
>
>
> UrlEncodedFormEntity requires a List<? extends UrlEncodedFormEntity> to pass
> it to URLEncodedUtils.format. It would be nice to use Iterable<? extends
> UrlEncodedFormEntity> to be able to use other collections, e.g. a Set<?
> extends UrlEncodedFormEntity>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
