[
https://issues.apache.org/jira/browse/HTTPCLIENT-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067677#comment-13067677
]
Jon Moore commented on HTTPCLIENT-1108:
---------------------------------------
@Oleg: regarding #deleteLeastUsedEntry, yes, you're right. I think there're
some unit tests missing here that I'll try to add while I fix this.
Regarding the data structure, let me get the functionality fixed first and then
we can discuss implementation and data structure. I think you've pointed out
that whatever we use, we need to be able to remove from both ends of the list,
depending on whether we want the most-recently or least-recently used
connection.
> different connection reuse strategy would reduce number of open connections
> ---------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1108
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1108
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 4.1.1
> Reporter: Jon Moore
> Assignee: Jon Moore
> Priority: Minor
> Fix For: 4.1.2
>
>
> Currently, the ThreadSafeClientConnManager reuses persistent connections in a
> round-robin fashion: when the connection is checked back into the pool, it is
> added to a queue of available connections for later use. This has the perhaps
> unintended effect that the client may keep open more connections than needed,
> because the "last used" time keeps getting updated and none of the
> connections can get reclaimed via closeIdleConnections().
> Exchanging the queue (FIFO) for a stack (LIFO) would result in extra
> connections actually becoming idle for long enough to be reclaimed.
> I have a working patch for this; just need to get my act together to get it
> in.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]