On 30 June 2012 15:09, Oleg Kalnichevski <[email protected]> wrote: > On Sat, 2012-06-30 at 14:59 +0100, sebb wrote: >> On 29 June 2012 21:59, Oleg Kalnichevski <[email protected]> wrote: >> > Please vote on releasing these packages as HttpComponents Client 4.2.1. >> > The vote is open for the at least 72 hours, and only votes from >> > HttpComponents PMC members are binding. The vote passes if at least >> > three binding +1 votes are cast and there are more +1 than -1 votes. >> > >> > Packages: >> > http://people.apache.org/~olegk/httpclient-4.2.1-RC1/ >> >> Unfortunately the file TestUriBuilder.java contains some non-ASCII >> characters, and is corrupt in the zip archive. >> > > Does this really have to be a release blocker?
I'm undecided. I just checked, and the test works with the mangled chars. However, I'm not 100% happy that the archives differ, so at present I'm abstaining. > Oleg > >> I think this is because the <fixcrlf> Ant tasks in >> src/main/assembly/build.xml need the encoding to be specified. >> >> The following setting works for me: >> >> encoding="iso-8859-1" >> >> It would also be possible to use UTF-8 if the file were fixed to use UTF-8. >> >> Note: the problem does not occur for me when the encoding is omitted, >> I think because my default encoding is suitable. >> >> > Release notes: >> > http://people.apache.org/~olegk/httpclient-4.2.1-RC1/RELEASE_NOTES.txt >> > >> > Maven artefacts: >> > https://repository.apache.org/content/repositories/orgapachehttpcomponents-290/org/apache/httpcomponents/ >> > >> > SVN tag: >> > https://svn.apache.org/repos/asf/httpcomponents/httpclient/tags/4.2.1-RC1/ >> > >> > -------------------------------------------------------------------------- >> > Vote: HttpComponents Client 4.2.1 release >> > [ ] +1 Release the packages as HttpComponents Client 4.2.1. >> > [ ] -1 I am against releasing the packages (must include a reason). >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
