[
https://issues.apache.org/jira/browse/HTTPCORE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431274#comment-13431274
]
Oleg Kalnichevski commented on HTTPCORE-307:
--------------------------------------------
Gary
There is actually no reason. In the early days of HttpCore I and Roland used to
make keep of the inner structures and internal methods protected per default
just in case someone might want to access or override them. This turned out to
be a rather bad idea. These days I tend to keep things private or package
visible per default until someone asks to make them protected.
Oleg
> Make HttpAsyncService.getRequestHandler() protected
> ---------------------------------------------------
>
> Key: HTTPCORE-307
> URL: https://issues.apache.org/jira/browse/HTTPCORE-307
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 4.2.1
> Reporter: William R. Speirs
> Fix For: 4.3-alpha1
>
> Attachments: HTTPCORE-307.diff
>
>
> Currently HttpAsyncService.getRequestHandler() is marked as private which
> makes implementing something like Virtual Host support very difficult because
> the only way resolve a Handler is by URI. Making
> HttpAsyncService.getRequestHandler() protected would allow someone to extend
> HttpAsyncService and resolve a handler based upon the whole HttpRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
