Chris Lott created HTTPCLIENT-1230:
--------------------------------------

             Summary: BasicClientConnectionManager is not thread safe, remove 
@ThreadSafe annotation
                 Key: HTTPCLIENT-1230
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1230
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient
    Affects Versions: 4.2 Final
            Reporter: Chris Lott
            Priority: Minor


I would like to suggest removing the @ThreadSafe annotation on 
BasicClientConnectionManager.  The javadoc clearly notes "it ought to be used 
by one execution thread only".  Seems like a basic contradiction.

Perhaps I am fundamentally not understanding the @ThreadSafe annotation.  I 
thought that meant the class either has no static fields and/or creates all new 
objects and/or handles all necessary synchronization so that any number of 
threads may share an instance. What does it mean here, on a class that wraps a 
single connection for which access must be synchronized?

Yes, after this problem bit us we switched to using 
PoolingClientConnectionManager.  

Thanks for considering this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to