[
https://issues.apache.org/jira/browse/HTTPCLIENT-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470003#comment-13470003
]
Jon Moore commented on HTTPCLIENT-1245:
---------------------------------------
No problem. Glad you're using the library and willing to report things you find!
> org.apache.http.impl.client.cache.memcached.SHA256KeyHashingScheme use of
> MessageDigest should be synchronized
> --------------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1245
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1245
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.2.1
> Reporter: Clinton Nielsen
>
> Function:
> public String hash(String key) {
> MessageDigest md = getDigest();
> md.update(key.getBytes());
> return Hex.encodeHexString(md.digest());
> }
> Should be rewritten to synchronize access to the MessageDigest object:
> public String hash(String key) {
> MessageDigest md = getDigest();
> byte[] digest = null;
> synchronized(md) {
> md.update(key.getBytes());
> digest = md.digest();
> }
> return Hex.encodeHexString(digest);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
