[
https://issues.apache.org/jira/browse/HTTPCLIENT-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13470215#comment-13470215
]
Francois-Xavier Bonnet commented on HTTPCLIENT-1240:
----------------------------------------------------
I am trying to find a better solution.
I have to main problems:
1) there are several places in the code where we create the HttpResponse (for
backend responses, cached responses, errors, not modified responses...) and
most of the time the request params and HttpClient params are not available.
Refactoring all that will be a lot of work. Another solution (but less clean)
is to concentrate on
org.apache.http.impl.client.cache.CachingHttpClient.execute(HttpHost,
HttpRequest, HttpContext) and add the params just before returning the
HttpResponse
2) adding calls to getParams() on HttpClient and HttpRequest breaks a lot of
EasyMock unit tests because these calls are not expected
The solution I can see to avoid to have too much code to change and to break
the unit tests would be in execute(HttpHost, HttpRequest, HttpContext) method
to return a wrapper that would contain the original HttpRespone, the
HttpRequest and the HttpClient so that it would be able to lazily build the
HttpParams (lazily so that it would not break the unit tests as they probably
do not call the method getParams()).
What do you think of this approach ?
> Empty HttpParams for cacheable requests
> ---------------------------------------
>
> Key: HTTPCLIENT-1240
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1240
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Cache
> Affects Versions: 4.2.1
> Reporter: Francois-Xavier Bonnet
> Priority: Minor
> Fix For: 4.3 Alpha1
>
>
> With DefaultHttpClient, HttpResponse.getParams() returns a ClientParamsStack
> with all the parameters previously set at HttpClient or HttpRequest level.
> With CachingHttpClient it returns an empty BasicHttpParams when a response is
> cached.
> This feature can be very usefull when you are doing complex processing with
> Interceptors for example. It is described in HttpClient documentation:
> http://hc.apache.org/httpcomponents-client-ga/tutorial/html/fundamentals.html#d5e299
> http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/ClientParamsStack.html
> CachingHttpClient should not break this feature.
> Here is some sample code:
> // Client and Request scoped params with DefaultHttpClient
> DefaultHttpClient httpClient = new DefaultHttpClient();
> httpClient.getParams().setParameter("testClientParam",
> "testClientParam");
> HttpGet httpGet = new
> HttpGet("http://www.google.fr/images/srpr/logo3w.png";);
> httpGet.getParams().setParameter("testRequestParam",
> "testRequestParam");
> HttpResponse response = httpClient.execute(httpGet);
> EntityUtils.consumeQuietly(response.getEntity());
>
> System.out.println(response.getParams().getParameter("testClientParam"));
>
> System.out.println(response.getParams().getParameter("testRequestParam"));
> // Same test with CachingHttpClient
> httpClient = new DefaultHttpClient();
> CachingHttpClient cachingHttpClient = new CachingHttpClient(httpClient);
> cachingHttpClient.getParams().setParameter("testClientParam",
> "testClientParam");
> httpGet = new HttpGet("http://www.google.fr/images/srpr/logo3w.png";);
> httpGet.getParams().setParameter("testRequestParam",
> "testRequestParam");
> response = cachingHttpClient.execute(httpGet);
> EntityUtils.consumeQuietly(response.getEntity());
>
> System.out.println(response.getParams().getParameter("testClientParam"));
>
> System.out.println(response.getParams().getParameter("testRequestParam"));
> If you agree I can provide a patch and unit tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![http://www.google.fr/images/srpr/logo3w.png"](https://www.google.fr/images/srpr/logo3w.png"){kind=link}