[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Boyers updated HTTPCLIENT-1246:
------------------------------------

    Description: 
Oleg asked me to submit this patch via JIRA.  This is an initial version of 
code to enable JMX for requests/timeouts/etc.

I've uploaded the patch as an attachment.

Here are my comments about what I have and have not done.  This is from an 
email earlier in the week:

What I have at this point is a version of a JmxEnabledHttpClient that 
implements the HttpClient interface.  You can instantiate a 
JmxEnabledHttpClient given an HttpClient.  I have decoupled it from the work I 
had done previously (Spring-dependent), so it works without any additional 
dependencies.  I probably just need a couple more hours to clean this area up.  
I did work on it a bit yesterday.

But I have not made progress in integrating the stats more closely with the 
HttpClient codebase.  So it doesn't currently have visibility into some of the 
underlying behavior of HttpClient and some of the mechanisms for retaining and 
managing statistics could probably be done more cheaply if they were integrated 
more closely.  This is the area I just don't think I'm going to be able to find 
the time to do, sadly.

So what I'm thinking at this point: I'll hand off what I've done (which is 
functional) and you guys can decide on whether or not to use it as the basis 
for anything going forward.  Even if you decide not to ultimately check it in 
with the rest of the HttpClient code, it could still be useful to you in the 
short-term, as it could easily be turned into its own jar and used with the 
existing HttpClient.  I'm pretty sure it records everything we talked about 
previous except the current pool size.

  was:
Oleg asked me to submit this patch via JIRA.  This is an initial version of 
code to enable JMX for requests/timeouts/etc.

I assume I'll be able to upload the patch to this JIRA after I've created it.

    
> Patch for JmxEnabledHttpClient
> ------------------------------
>
>                 Key: HTTPCLIENT-1246
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1246
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: HttpClient
>            Reporter: Mike Boyers
>         Attachments: jmx-enabled-httpclient.patch
>
>
> Oleg asked me to submit this patch via JIRA.  This is an initial version of 
> code to enable JMX for requests/timeouts/etc.
> I've uploaded the patch as an attachment.
> Here are my comments about what I have and have not done.  This is from an 
> email earlier in the week:
> What I have at this point is a version of a JmxEnabledHttpClient that 
> implements the HttpClient interface.  You can instantiate a 
> JmxEnabledHttpClient given an HttpClient.  I have decoupled it from the work 
> I had done previously (Spring-dependent), so it works without any additional 
> dependencies.  I probably just need a couple more hours to clean this area 
> up.  I did work on it a bit yesterday.
> But I have not made progress in integrating the stats more closely with the 
> HttpClient codebase.  So it doesn't currently have visibility into some of 
> the underlying behavior of HttpClient and some of the mechanisms for 
> retaining and managing statistics could probably be done more cheaply if they 
> were integrated more closely.  This is the area I just don't think I'm going 
> to be able to find the time to do, sadly.
> So what I'm thinking at this point: I'll hand off what I've done (which is 
> functional) and you guys can decide on whether or not to use it as the basis 
> for anything going forward.  Even if you decide not to ultimately check it in 
> with the rest of the HttpClient code, it could still be useful to you in the 
> short-term, as it could easily be turned into its own jar and used with the 
> existing HttpClient.  I'm pretty sure it records everything we talked about 
> previous except the current pool size.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to