[
https://issues.apache.org/jira/browse/HTTPCLIENT-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473585#comment-13473585
]
Justus Pendleton commented on HTTPCLIENT-1248:
----------------------------------------------
I guess I won't complain too much if this is intended behaviour, though I would
have thought unattended behaviour -- rather than human attended browsers --
would be a more common use case for clients of the library. In any case, I
would suggest that the Javadoc be enhanced with the above explanation. I didn't
expect "automatically redirect all POSTs" to mean "turn them into a GET and
throw away the body" :) Then again, I seem to be the only one who has
complained so far ;).
Thanks for the quick replies Jon & Oleg!
> LaxRedirectStrategy converts POST to GET and throws away body
> -------------------------------------------------------------
>
> Key: HTTPCLIENT-1248
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1248
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.2.1
> Reporter: Justus Pendleton
> Fix For: 4.2.2
>
>
> The LaxRedirectStrategy extends the DefaultRedirectStrategy. The
> DefaultAsyncRequestDirector calls _redirectStrategy.isRedirected()_ and
> LaxRedirectStrategy will return *true* on a POST. Then the director calls
> _redirectStrategy.getRedirect()_. The LaxRedirectStrategy doesn't implement
> this method so the one in the DefaultRedirectStrategy is called:
> {code}
> if (method.equalsIgnoreCase(HttpHead.METHOD_NAME)) {
> return new HttpHead(uri);
> } else {
> return new HttpGet(uri);
> }
> {code}
> This turns the POST into a GET on redirect. IMHO the LaxRedirectStrategy
> should be
> {code}
> public HttpUriRequest getRedirect(
> final HttpRequest request,
> final HttpResponse response,
> final HttpContext context) throws ProtocolException {
> URI uri = getLocationURI(request, response, context);
> String method = request.getRequestLine().getMethod();
> if (method.equalsIgnoreCase(HttpHead.METHOD_NAME)) {
> return new HttpHead(uri);
> else if (method.equalsIgnoreCase(HttpPost.METHOD_NAME)) {
> return new HttpPost(uri);
> } else if (method.equalsIgnoreCase(HttpGet.METHOD_NAME)) {
> return new HttpGet(uri);
> } else {
> throw new IllegalStateException("Redirect called on
> un-redirectable http method: " + method);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
