On Wed, 2012-10-10 at 22:11 +0100, sebb wrote: > On 10 October 2012 21:51, <[email protected]> wrote: > > Author: olegk > > Date: Wed Oct 10 20:51:30 2012 > > New Revision: 1396793 > > > > URL: http://svn.apache.org/viewvc?rev=1396793&view=rev > > Log: > > HTTPCLIENT-1248: Default and lax redirect strategies should not convert > > requests redirected with 307 status to GET method > >
... > The above code converts unknown methods into GET. > If a new method is added, that will be incorrect. > > It might be useful to know when this is happening; maybe an assert > would be useful here? > Or a log message? > > Or is it possible to write a clone/copy method that works for all > possible methods? > Maybe methods should know how to clone themselves? > This is a good point. I reworked the method to make use of the new RequestBuilder class to create a mutable copy of the original request prior to setting the request URI. http://svn.apache.org/viewvc?rev=1397085&view=rev Please review Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
