[
https://issues.apache.org/jira/browse/HTTPCLIENT-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noah Levitt updated HTTPCLIENT-1285:
------------------------------------
Description:
In InternalHttpClient.doExecute() even if HttpClientContext requestConfig has
been set, it gets replaced. Not sure what the intent is here as far as which
config should take precedence, but if "request" doesn't provide a
RequestConfig, I would certainly expect the HttpClientContext requestConfig to
carry through.
HttpClientContext localcontext = setupContext(context);
HttpRoute route = determineRoute(target, wrapper, localcontext);
RequestConfig config = null;
if (request instanceof Configurable) {
config = ((Configurable) request).getConfig();
}
if (config == null) {
config = this.defaultConfig;
}
if (config == null) {
config = HttpClientParamConfig.getRequestConfig(params);
}
localcontext.setRequestConfig(config);
This is in trunk as of r1414680
was:
In InternalHttpClient.doExecute() even if HttpClientContext requestConfig has
been set, it gets replaced. Not sure what the intent is here as far as which
config should take precedence, but if "request" doesn't provide a
RequestConfig, I would certainly expect the HttpClientContext requestConfig to
carry through.
{code}
HttpClientContext localcontext = setupContext(context);
HttpRoute route = determineRoute(target, wrapper, localcontext);
RequestConfig config = null;
if (request instanceof Configurable) {
config = ((Configurable) request).getConfig();
}
if (config == null) {
config = this.defaultConfig;
}
if (config == null) {
config = HttpClientParamConfig.getRequestConfig(params);
}
localcontext.setRequestConfig(config);
{code}
> InternalHttpClient.doExecute() clobbers context request config
> --------------------------------------------------------------
>
> Key: HTTPCLIENT-1285
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1285
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: Snapshot
> Reporter: Noah Levitt
>
> In InternalHttpClient.doExecute() even if HttpClientContext requestConfig has
> been set, it gets replaced. Not sure what the intent is here as far as which
> config should take precedence, but if "request" doesn't provide a
> RequestConfig, I would certainly expect the HttpClientContext requestConfig
> to carry through.
> HttpClientContext localcontext = setupContext(context);
> HttpRoute route = determineRoute(target, wrapper, localcontext);
> RequestConfig config = null;
> if (request instanceof Configurable) {
> config = ((Configurable) request).getConfig();
> }
> if (config == null) {
> config = this.defaultConfig;
> }
> if (config == null) {
> config = HttpClientParamConfig.getRequestConfig(params);
> }
> localcontext.setRequestConfig(config);
> This is in trunk as of r1414680
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
