[ 
https://issues.apache.org/jira/browse/HTTPCORE-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542079#comment-13542079
 ] 

Oleg Kalnichevski commented on HTTPCORE-325:
--------------------------------------------

Noah,
I am very uncomfortable with the idea of making internal variable and methods 
of Session*BufferImpls protected. I would like the inner structures and methods 
of those classes remain private. I have not thoroughly studied Heritrix classes 
you are referring to but I cant help thinking that you would be much better off 
decorating Socket input stream the session buffer binds to, rather than session 
buffer itself.

Oleg
                
> support custom implementations of SessionInputBuffer and SessionOutputBuffer
> ----------------------------------------------------------------------------
>
>                 Key: HTTPCORE-325
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-325
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>    Affects Versions: 4.3-alpha2
>            Reporter: Noah Levitt
>         Attachments: httpcore-325-20121231182846.diff
>
>
> In heritrix we have a set of classes that wrap streams and record them 
> verbatim for replay. One of the things it needs to do is make a note of where 
> the http headers end and the message body begins. In order to make this work 
> with httpcomponents I found I needed custom implementations of 
> Session*Buffer. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to