[
https://issues.apache.org/jira/browse/HTTPCLIENT-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549290#comment-13549290
]
Karl Wright commented on HTTPCLIENT-1296:
-----------------------------------------
I also have a trivial test that demonstrates the problem and fix; I will
include this if I get the go-ahead for inclusion in 4.2.3. Meanwhile I'm going
to apply both the fix and the test to trunk.
> Null pointer exception when using default host and virtual host with port -1
> ----------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1296
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1296
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Affects Versions: 4.2.2
> Reporter: Karl Wright
> Assignee: Karl Wright
> Priority: Critical
> Attachments: HTTPCLIENT-1296.patch
>
>
> The following code in DefaultRequestDirector is incorrect:
> {code}
> // HTTPCLIENT-1092 - add the port if necessary
> if (virtualHost != null && virtualHost.getPort() == -1) {
> int port = target.getPort();
> if (port != -1){
> virtualHost = new HttpHost(virtualHost.getHostName(), port,
> virtualHost.getSchemeName());
> }
> }
> {code}
> The reason it is incorrect is that if the target has not been specified in
> the URL, then an NPE will result. The target is resolved later in the same
> method in that case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
