On 10 February 2013 10:20, Oleg Kalnichevski <[email protected]> wrote: > ... >> The Javadoc should mention that the param is ignored unless > 0. >> > + * @see SocketOptions#SO_SNDBUF >> > + */ >> > + @Deprecated >> >> Huh? Why add a deprecated method? >> If it is really deprecated from birth, should include @deprecated >> Javadoc tag with details of replacement. >> > > This class started out as a classic mutable java bean with setters and > getters. In 4.3 setters got deprecated in favor of a builder, which > should allow us to make the class fully immutable in the future. I added > those setters for consistency sake.
OK, I see > Added @deprecated javadoc tags in trunk. > > http://svn.apache.org/viewvc?view=revision&revision=r1444523 Thanks, that looks good. > Oleg > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
