On 8 May 2013 15:04, <[email protected]> wrote: > Author: olegk > Date: Wed May 8 14:04:29 2013 > New Revision: 1480281 > > URL: http://svn.apache.org/r1480281 > Log: > Suppress resource leak warning for HttpClientExchangeHandler instances > > Modified: > > httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/InternalHttpAsyncClient.java > > httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/MinimalHttpAsyncClient.java > > Modified: > httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/InternalHttpAsyncClient.java > URL: > http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/InternalHttpAsyncClient.java?rev=1480281&r1=1480280&r2=1480281&view=diff > ============================================================================== > --- > httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/InternalHttpAsyncClient.java > (original) > +++ > httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/InternalHttpAsyncClient.java > Wed May 8 14:04:29 2013 > @@ -175,6 +175,7 @@ class InternalHttpAsyncClient extends Cl > context != null ? context : new BasicHttpContext()); > setupContext(localcontext); > > + @SuppressWarnings("resource")
Why is it safe to ignore the warning? It would help to have an inline comment to explain the reason it's OK. > final DefaultClientExchangeHandlerImpl<T> handler = new > DefaultClientExchangeHandlerImpl<T>( > this.log, > requestProducer, > > Modified: > httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/MinimalHttpAsyncClient.java > URL: > http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/MinimalHttpAsyncClient.java?rev=1480281&r1=1480280&r2=1480281&view=diff > ============================================================================== > --- > httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/MinimalHttpAsyncClient.java > (original) > +++ > httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/MinimalHttpAsyncClient.java > Wed May 8 14:04:29 2013 > @@ -149,6 +149,7 @@ class MinimalHttpAsyncClient extends Clo > final HttpClientContext localcontext = HttpClientContext.adapt( > context != null ? context : new BasicHttpContext()); > > + @SuppressWarnings("resource") > final MinimalClientExchangeHandlerImpl<T> handler = new > MinimalClientExchangeHandlerImpl<T>( > this.log, > requestProducer, > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
