On Mon, 2013-06-17 at 14:52 +0100, sebb wrote: > At present, the classes ChunkEncoder and LengthDelimitedEncoder both > use the code > > this.completed = true; > > This is equivalent to super.complete(); these are the only remaining > external acceses to the field. > > Any objections to making that change? > > The completed field can then be deprecated so accidental external > access will be flagged. > > One day we can make it private, which will stop completed from ever > being reset back to false (which I assume would cause some problems!)
This will probably help make FindBugs reports look prettier but will hardly make a difference unless we make a decision to stop using direct access to protected variables consistently across the code base. Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
