[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741620#comment-13741620
 ] 

Sebb commented on HTTPCLIENT-1387:
----------------------------------

I realise that there is no runtime guarantee. Generics warnings are 
compile-time only. 
However we should strive for code that does not fail with CCEs provided that 
there are no compile-time warnings.

If we are sure that the REDIRECT_LOCATIONS attribute can only contain URIs, 
then the @SuppressWarnings is OK, and we should document that. However if 
REDIRECT_LOCATIONS is not compile-time safe, then we should note that.

The generics warnings are not perfect, but they can catch coding errors.

The point of commenting the suppression is to show that the issue has been 
considered, not just ignored, so that only unavoidable warnings are suppressed.
                
> Replace URICollection with List<URI>
> ------------------------------------
>
>                 Key: HTTPCLIENT-1387
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1387
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.3 Beta2
>            Reporter: James Leigh
>              Labels: patch
>             Fix For: 4.3 Final
>
>         Attachments: HTTPCLIENT-1387.patch
>
>
> The 4.3 API should use List<URI> interface (as opposed to URICollection) for 
> redirect locations, while also providing 4.2 RedirectLocations binary 
> compatibility.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to