Agreed. The vote is about whether to release the source bits. EOL-style considerations between SVN and the source release really do not apply here. It's a nice-to-have, not a make-or-break.
Karl On Mon, Sep 2, 2013 at 1:28 PM, Oleg Kalnichevski <[email protected]> wrote: > On Mon, 2013-09-02 at 21:59 +0530, Asankha C. Perera wrote: > > On 09/02/2013 06:06 PM, Oleg Kalnichevski wrote: > > > On Mon, 2013-09-02 at 11:53 +0100, sebb wrote: > > > ... > > > > > > Further httpclient/src/test/resources/suffixlist.txt has got EOL=LF in > > > the zip file so it disagrees with the SVN tag checkout. > > > > > > Also, the *.properties files ought to be CRLF on Windows (they are > > > native in SVN) > > > Likewise *.xsl and *.css and SPNEGO.svg > > > Otherwise checkouts of the tag don't agree with the Zip > > > > > > I am sorry but I have no idea what this is all about. I have no idea > why > > > they should agree in the first place. > > I guess Sebastian's concern is that if you unzip the Zip on a Windows > > box, and compare the result with a checkout of the tag on the same > > Windows system, the line endings would be different between the two for > > some files. Although that maybe a minor issue, if the differences are > > related only to the line endings of a few files, I would not consider it > > a blocker to the release. Personally I consider differences in line > > endings as ignorable, and many IDEs or file compare tools also tend to > > ignore them. I guess one who would look for the source releases would > > prefer to get it directly via the SVN tag, and ones who download the > > source archive of a release would generally want to refer to the code > > for understanding or debugging etc - so the line endings would not be > > that critical - my 2c > > Asankha > I understand the technical bits. What I do not understand is why that > would matter at all, why anyone in their sane mind would want to compare > SVN tag with the content of ZIP archive and why on earth we need to > waste our collective time on stuff like that? > > Oleg > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
