Sebastiano Vigna created HTTPCLIENT-1434:
--------------------------------------------
Summary: TrustSelfSignedStrategy should be a singleton
Key: HTTPCLIENT-1434
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1434
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: HttpClient
Affects Versions: 4.3.1
Reporter: Sebastiano Vigna
Priority: Trivial
TrustSelfSignedStrategy should be a singleton, as it happens for several other
strategies in HTTP Client. For example,
public class TrustSelfSignedStrategy implements TrustStrategy {
public static final TrustSelfSignedStrategy INSTANCE = new
TrustSelfSignedStrategy();
private TrustSelfSignedStrategy() {}
public boolean isTrusted(
final X509Certificate[] chain, final String authType) throws
CertificateException {
return chain.length == 1;
}
}
Incidentally, I noted that other strategies (e.g., NoConnectionReuseStrategy)
have a public constructor, which violates the Singleton design pattern.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
