Sebb created HTTPCORE-363:
-----------------------------
Summary: Unnecessary call to isOpen() before calling close
Key: HTTPCORE-363
URL: https://issues.apache.org/jira/browse/HTTPCORE-363
Project: HttpComponents HttpCore
Issue Type: Improvement
Reporter: Sebb
Priority: Minor
There are some instances of the following code:
final Channel channel = this.key.channel();
if (channel.isOpen()) {
try {
channel.close();
} catch (final IOException ignore) {}
}
Eclipse generates a warning that the channel might not be closed.
Obviously that is a false positive, but why bother checking the state?
Surely channel.close() can be repeated without harm?
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
