[
https://issues.apache.org/jira/browse/HTTPCLIENT-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870254#comment-13870254
]
Joe Campbell commented on HTTPCLIENT-1347:
------------------------------------------
So - I agree that in this case I think that the parent shouldn't contain the
variant body (meaning that there would be just a single item but there would
still be two entries), however in the case of variants and the storage - there
has to be a root item, that points to all the variants each variant is a
different item.
I may or may not agree that the 'storage' is inefficient, it is however
technically correct according to the HTTP spec. in this case. The variant key
isn't Accept-Encoding=<BLANK> - the variant key must indicate what type of
variant it is as there can be many and each one might be a different response.
For instance, if it stored your gzipped response at a single variant marked
Accept-Encoding, then you made a request for Accept-Encoding deflate you would
get a gzipped response from the cache which would be wrong.
> gzip responses doubly cached
> ----------------------------
>
> Key: HTTPCLIENT-1347
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1347
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpCache
> Affects Versions: 4.2.5
> Environment: ARCH Linux kernel 3.8.8-1
> node.js 0.8.22
> Reporter: Adam Patacchiola
> Fix For: 4.4 Final
>
> Attachments: Screen Shot 2014-01-11 at 7.11.36 PM.png, Screen Shot
> 2014-01-13 at 3.56.19 PM.png, Showing_entry_pointer.png,
> httpClientCacheTest.tar.gz, httpClientTestServer.js
>
>
> Compressed responses are cached twice.
> Run the attached server (node.js 0.8.22) and client tests. Create an "assets"
> directory under where you are running the server and add two files named 1
> and 2 ( < 1000000 bytes) . You will see that after the test is run the cache
> dump output displays 2 sets of entries for each request, each containing the
> full content length of the file.
> Changing the implementation of HttpCacheStorage updateEntry to not update non
> existent entries (as I believe the correct implementation should do) throws
> exceptions.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
