On Thu, 2014-02-20 at 13:34 +0000, sebb wrote: > On 20 February 2014 10:59, Oleg Kalnichevski <[email protected]> wrote: > > On Wed, 2014-02-19 at 21:39 +0000, sebb wrote: > >> On 19 February 2014 20:05, Oleg Kalnichevski <[email protected]> wrote: > >> > On Wed, 2014-02-19 at 18:49 +0000, sebb wrote: > >> >> If a connection is dropped by the remote server, the code in HC 4.2.x > >> >> throws an Exception. > >> >> This is not shown in the wire log, which makes the log harder to > >> >> follow that it could be. > >> >> [e.g. why is the next action a close?] > >> >> > >> >> I think it would be useful to treat the event as something that needs > >> >> to be logged as part of wire ERROR logging. This does not happen > >> >> currently in 4.2.x. I have not checked the 4.3 code. > >> >> > >> >> Make sense? > >> >> > >> > > >> > It does. Would you like to implement this feature your self or shall I > >> > do it? > >> > >> I don't have a burning desire to implement it, so if you are happy to > >> do so, please go ahead. > >> > > > > Could you please review / test? > > > > http://svn.apache.org/r1570138 > > The patches include some unrelated (possibly incorrect) changes, noted > in replies to the commit message. > > Also, it would useful to identifiy the method that has detected the error. > i.e. was it read/close/reset/flush that caused the error? > > Probably no need to identify which read method is involved, but > distinguishing read from skip would be useful. >
Done. Please review. Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
