On Mon, 2014-06-09 at 11:13 -0400, Jon Moore wrote: > What's the established mechanism for handling pull requests on the Github > mirror of the project? For example, I have commentary on the PR below but > am not sure whether I should comment on the PR itself or if I should > redirect the contributor to the official JIRA / patchset process. I > couldn't find this described on our website or wiki anywhere. > > Thanks, > Jon >
Hi Jon Based purely on my personal interpretation of this blog [1] it should be perfectly OK to comment on the PR at GitHub. However, for substantial contributions like this one a JIRA should still be raised and linked with the PR at GitHub Oleg [1] https://blogs.apache.org/infra/entry/improved_integration_between_apache_and > > On Sun, Jun 8, 2014 at 10:40 AM, TJ-Cutajar <[email protected]> wrote: > > > GitHub user TJ-Cutajar opened a pull request: > > > > https://github.com/apache/httpclient/pull/13 > > > > Added the ability to cache responses to HEAD requests > > > > A subsequent GET request to the same URI will result in a call to > > origin. A cache entry that exists from a previous GET can be used to > > satisfy a HEAD request. > > > > You can merge this pull request into a Git repository by running: > > > > $ git pull https://github.com/TJ-Cutajar/httpclient > > cache-head-responses > > > > Alternatively you can review and apply these changes as the patch at: > > > > https://github.com/apache/httpclient/pull/13.patch > > > > To close this pull request, make a commit to your master/trunk branch > > with (at least) the following in the commit message: > > > > This closes #13 > > > > ---- > > commit 238bae0ff77ac1419a95b51f8152875ff45c1f12 > > Author: Tyrone Cutajar <[email protected]> > > Date: 2014-06-08T14:25:20Z > > > > Added the ability to cache responses to HEAD requests. Subsequent GET > > requests to the same URI result in a call to origin. A cache entry that > > exists from a previous GET can be used to satisfy a HEAD request. > > > > ---- > > > > > > --- > > If your project is set up for it, you can reply to this email and have your > > reply appear on GitHub as well. If your project does not have this feature > > enabled and wishes so, or if the feature is enabled but not working, please > > contact infrastructure at [email protected] or file a JIRA ticket > > with INFRA. > > --- > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
