[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134113#comment-14134113
 ] 

Sebb commented on HTTPCLIENT-1471:
----------------------------------

So the current Set implementation is about 42% slower than binSearch and 11% 
slower than linear int search (though of course a suitable ordering scheme 
would help in the general case). The actual times are of course quite small.

> ResponseCachingPolicy - eliminate boxing and HashSet
> ----------------------------------------------------
>
>                 Key: HTTPCLIENT-1471
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1471
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpCache
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 4.4 Final
>
>
> ResponseCachingPolicy uses 2 HashSets containing a few Integers each for 
> matching int values.
> This involves lots of boxing plus the overhead of the hashSet.
> Since the numbers of integers involved is very small - at most 6 - it seems 
> unnecessary to use hashing. A linear search would likely be quicker.
> If the number of entries were to be rather larger, then Arrays#binarySearch 
> might be better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to