[
https://issues.apache.org/jira/browse/HTTPCLIENT-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137247#comment-14137247
]
Rob Smit edited comment on HTTPCLIENT-1554 at 9/17/14 2:02 PM:
---------------------------------------------------------------
Yes, by checking out the source from 4.3.5 from git and running the tests, I
can not reproduce the problem. Using android the HttpRequest contains an empty
array params attribute.
Indeed the source of the problem is that in android code the HttpRequest has no
null params (new HttpGet(url)). a work a round could be setting explicitely
(request.setParams(null)) but gives:
java.lang.IllegalArgumentException: HTTP parameters may not be null
was (Author: robsmit):
Yes, by checking out the source and running test, I can not reproduce. Using
android the HttpRequest contains an empty array params attribute.
Indeed the source of the problem is that in android code the HttpRequest has no
null params (new HttpGet(url)). a work a round could be setting explicitely
(request.setParams(null)) but gives:
java.lang.IllegalArgumentException: HTTP parameters may not be null
> defaultRequestConfig never used in InternalHttpClient
> -----------------------------------------------------
>
> Key: HTTPCLIENT-1554
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1554
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.3.5
> Environment: android
> Reporter: Rob Smit
> Labels: HttpClient
>
> after initializing builder en building client, the timeout settings are not
> used for the request execution. In ClosableHttpClient.doExecute(), an on the
> fly request config is used.
> my code:
> builder = HttpClientBuilder.create();
> int timeout = 30000;
> defaultRequestConfig = RequestConfig.custom()
> .setSocketTimeout(timeout)
> .setConnectTimeout(timeout)
> .build();
> builder.setDefaultRequestConfig(defaultRequestConfig);
> List<Header> headers = new ArrayList<Header>();
> headers.add(new BasicHeader("Accept", "application/json"));
> builder.setDefaultHeaders(headers);
> builder.useSystemProperties();
> client = builder.build();
> client.execute(request)
> timeout settings are never used!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
