[
https://issues.apache.org/jira/browse/HTTPCLIENT-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137611#comment-14137611
]
Kurian Abraham edited comment on HTTPCLIENT-1553 at 9/17/14 5:52 PM:
---------------------------------------------------------------------
This should probably use SSLConnectionFactory.getSystemSocketFactory() and
SSLConnectionFactory.getSocketFactory() instead of hardcoding
SSLCertificateSocketFactory. That will also incorporate the other SSL socket
timeout bugfix fix into HttpClientBuilder other wise it will still use an
indefinite timeout.
was (Author: kathampy):
This should probably use SSLConnectionFactory.getSocketFactory() instead of
hardcoding SSLCertificateSocketFactory. That will also incorporate the other
SSL socket timeout bugfix fix into HttpClientBuilder other wise it will still
use an indefinite timeout.
> SSLSocketFactory null argument exception in HttpClientBuilder.build() if
> system properties are not used.
> --------------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1553
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1553
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: Android Port
> Affects Versions: 4.3.5
> Reporter: Kurian Abraham
> Labels: easyfix
> Fix For: 4.3.5.1-android
>
>
> The outer systemProperties check is unnecessary and causes it to fail.
> if (systemProperties) {
> if (systemProperties) {
> sslSocketFactory = new SSLConnectionSocketFactory(
> (SSLSocketFactory) SSLCertificateSocketFactory.getDefault(0),
> supportedProtocols, supportedCipherSuites, hostnameVerifier);
> } else {
> sslSocketFactory = new SSLConnectionSocketFactory(
> (SSLSocketFactory) SSLCertificateSocketFactory.getDefault(0),
> hostnameVerifier);
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
